perfsonar-dev - [pS-dev] [GEANT/SA2/ps-java-services] r6017 - trunk/perfsonar_base/src/main/java/org/perfsonar/base/au xiliary/components/mapping
Subject: perfsonar development work
List archive
[pS-dev] [GEANT/SA2/ps-java-services] r6017 - trunk/perfsonar_base/src/main/java/org/perfsonar/base/au xiliary/components/mapping
Chronological Thread
- From:
- To:
- Subject: [pS-dev] [GEANT/SA2/ps-java-services] r6017 - trunk/perfsonar_base/src/main/java/org/perfsonar/base/au xiliary/components/mapping
- Date: Fri, 5 Oct 2012 10:22:54 +0100 (BST)
Author: nordunet.behrmann
Date: 2012-10-05 10:22:54 +0100 (Fri, 05 Oct 2012)
New Revision: 6017
Modified:
trunk/perfsonar_base/src/main/java/org/perfsonar/base/auxiliary/components/mapping/ExpressionMapping.java
Log:
perfsonar_base: Fix bug in dead code
getMapping ignored the return value of String.replaceAll. The code was not
used (at least not in SQL MA).
Issue: PSSERVICES-597
Modified:
trunk/perfsonar_base/src/main/java/org/perfsonar/base/auxiliary/components/mapping/ExpressionMapping.java
===================================================================
---
trunk/perfsonar_base/src/main/java/org/perfsonar/base/auxiliary/components/mapping/ExpressionMapping.java
2012-10-05 09:22:53 UTC (rev 6016)
+++
trunk/perfsonar_base/src/main/java/org/perfsonar/base/auxiliary/components/mapping/ExpressionMapping.java
2012-10-05 09:22:54 UTC (rev 6017)
@@ -133,9 +133,9 @@
String replacement)
{
String out = mappings.get(mappingName);
- if (pattern != null & out != null && replacement != null) {
+ if (pattern != null && out != null && replacement != null) {
String regexp = "\\%" + pattern + "\\%";
- out.replaceAll(regexp, replacement);
+ out = out.replaceAll(regexp, replacement);
}
return out;
- [pS-dev] [GEANT/SA2/ps-java-services] r6017 - trunk/perfsonar_base/src/main/java/org/perfsonar/base/au xiliary/components/mapping, svn-noreply, 10/05/2012
Archive powered by MHonArc 2.6.16.