perfsonar development work

["Michael Bischoff" <>]

>
> Hi Michael,
>
>
> I see that you have done some updates in the base. I've skimmed them
> quickly and they seems to improve some things. Could you send some
> information about them and the intention behind? The base is a core piece
> of all our java services and its changes are crucial. We have to be sure
> that they are tested and known by other developers before committing to
> the final svn location.
>
>
> Roman
>

- Mostly I've added Logging and result(error) codes where appropriate.
Logging involves mainly changing stuff as "something went wrong" into
"couldn't find file I was looking here: \home\foo\bar"

especially in the case of a missing "object.config" where it only returned
along the lines of "could not parse Message".

- Fixed javadoc here and there (although not thoroughly)

- Removed white spaces

Some stuff that I checked in but wasn't planning on it till later, changes
where tested throughout but not against other serivces, most of actual
code changes are additions(additional recover attempts) and shouldn't
break stuff but bugs are subtle like that, anyways my bad:

List of changes:

- Refactored insanely long methods and broken them up in a couple of

Below is a method as found in AuxiliaryComponentManager that provides a
single way of looking up files and also looks in the path relative to
WEB-INF (to avoid absolute file names and break quick deploying)

/**
 * Profides a consistent way to lookup files within perfsonar.
 * @return URL containting the path or null if not found.
 */
public static URL lookupFile(String file);

Some threading issues where avoided by applying common practices, creating
and checking of the singleton was not thread-safe.

all in all quite some lines where affected but mostly cleanup.


ps. sorry roman for recieving this mail twice (forgot to cc
)