perfsonar development work

[Loukik Kudarimoti <>]

Roman Lapacz wrote:
> Loukik Kudarimoti wrote:
> > Hi Roman,
> >
> > I was having a look into your class to understand how to communicate 
> > with ExistDBStorageManager (my mp sources are broken). I noticed this 
> > relationship
> >
> > public class SQLTypeMAServiceEngine extends RRDTypeMAServiceEngine
> >
> > I don't understand this inheritance (or the need for it). Can you 
> > please explain it to me?
> Hi Loukik,
>
> Both classes are very similar and SQL service engine, which was 
> created later, can use some stuff of RRD service engine (for example 
> getKey method). Of course this could be done other way (creating an 
> object of RRD service engine inside SQL service engine and using its 
> method or repetition of the code or creating another abstract class; 
> if you have similar situation in your services it's up to you what you 
> will choose according to your experience) but I chose this solution 
> because it's comfortable and don't break any logical/implementation 
> rules.
I agree that it doesn't break any implementation rules as such. Without 
wanting to make it sound anything like a protest and keeping in mind 
that you are responsible for both the services, I would like to express 
my concern here that SQL MA is dependent on a component which is part of 
RRD MA. So, if I want to package only SQL MA into a pS Release or if I 
want to install only SQL MA, I would be using components from RRD MA.

For me, this inheritance is not 'natural'. I feel that there could be 
something missing in our ps-Base because of which we have this case. I 
guess this is something for us to think about for the future of ps-Base.

Loukik.
> Roman
>
> > thanks,
> > Loukik