Skip to Content.
Sympa Menu

ndt-dev - [ndt-dev] [ndt-project/ndt] 713766: web100clt.c: make results parsing more robust

Subject: NDT-DEV email list created

List archive

[ndt-dev] [ndt-project/ndt] 713766: web100clt.c: make results parsing more robust


Chronological Thread 
  • From: GitHub <>
  • To:
  • Subject: [ndt-dev] [ndt-project/ndt] 713766: web100clt.c: make results parsing more robust
  • Date: Fri, 17 Feb 2017 09:09:31 -0800
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=github.com; s=mailo; q=dns; h=Sender: Date: From: Reply-To: To: Message-ID: Subject: Mime-Version: Content-Type: Content-Transfer-Encoding; b=je2UQeydgGgqy96meNdQVioPSokdGgrIqZtPcfNuu5WohRQmFM8yDGnAV1coqWPw7FNpgn wlhYvemKV1cZhTuvmnalq27gc2qR1Pmc6NlVX9gPlcIECqeH7UlMrkt6x0Hxxo79R1hv3KSS 5hKdqaHe55efK/5tRT85SROBFtvfs=
  • Ironport-phdr: 9a23:FcTulBF1DpJPG3Ha43tpu51GYnF86YWxBRYc798ds5kLTJ7zr8qwAkXT6L1XgUPTWs2DsrQf2reQ6/6rCDFIyK3CmUhKSIZLWR4BhJdetC0bK+nBN3fGKuX3ZTcxBsVIWQwt1Xi6NU9IBJS2PAWK8TW94jEIBxrwKxd+KPjrFY7OlcS30P2594HObwlSijewZbN/IA+qoQjQucUbhYtvIbstxxXUpXdFZ/5Yzn5yK1KJmBb86Maw/Jp9/ClVpvks6c1OX7jkcqohVbBXAygoPG4z5M3wqBnMVhCP6WcGUmUXiRVHHQ7I5wznU5jrsyv6su192DSGPcDzULs5Vyiu47ttRRT1jioMKjw3/3zNisFogqxVoAihqQJ8zYDJb46aKPVwc7jYfd4YX2dMRNpdWzBDD466coABD/ABPeFdr4TlplUOrAe+CwuxBOz01zRFgXn23aog0+s/CQHG2AwhEskBsHTVsNX1NLoSXvuvwKbUyjXDaupb1DHg44bGdRAhpOuDXbN2ccfJzEkgCRnKjk6NqYz/ITyV0/oCs26H7+Z5UeKgkXUopxt2oji1yccgkobJhoMJylDE6CV225w5KsG/SE5+Z9OvDZhetzmCOodrQ84vQntktSQ5x7EcuJO2eDIGxIkmyhPbc/CLboyF7gz5WOufPTt0nmxpdbKhixqo/kWs1OvxXdSu3llQtCpKiNzMu2gN1xPN7siHTeNw/kKg1DuLzgzf9+BJLEQumareMZEhw7owlpUOsUTFBCP2nlv5jLOOekUl/Oin9fjnb637qpKdNoJ4kAPzP6c0lsG+Bek0KBUCUmmf9Oik0b3s50z5QLFEjv0slanZtYjXKt8cpq6kBQ9azpgs5xG+AjqpzdgVmWQLIVJfdB+Ik4TpNUjCIPblAvejmlijjSlkx+7eM73gBJXNMmbMkK3nfblj905Q1hA/ws5C6JJJEbwBL/PzWlPxtNzFFRA1KRC7w+HiCNllzIMRRXqPArOFMKPVqVKI4P8gI/WVaIAIpjn9NeMo5/rvjX8ihV8dZrel0YEWaHC+AvRpPV+ZYXzyjdcdD2sGpBQxQ/H3iA7KbTkGYXquGq4x+Bk6Dp6rF4HOWtrrjbCcjx22BplHWmcTJVGQMWriP9GCXO0BcCaDCsBgjjwZX/6qTIp3hj+0swqv5Lt7DvfesnkesojuzNxkz+LSiREv/3p/CMHLgDLFdH19gm5dH2x+56t4u0Eoklo=

Branch: refs/heads/master
Home: https://github.com/ndt-project/ndt
Commit: 7137663e03c2b643f6e12da31c327cc7fd532a80

https://github.com/ndt-project/ndt/commit/7137663e03c2b643f6e12da31c327cc7fd532a80
Author: Simone Basso
<>
Date: 2017-01-07 (Sat, 07 Jan 2017)

Changed paths:
M src/web100clt.c

Log Message:
-----------
web100clt.c: make results parsing more robust

1) Do not assume that the first line we receive contains a space

2) Do not assume that the first line we receive contains an integer

3) Be robust to the case where input is an empty string

4) Do not assume that after the first token delimited by space we
will find a second token delimited by newline

Tested under the following conditions:

a) web100clt -n ndt.iupui.mlab1.trn01.measurement-lab.org that sends
back all variables and checked via printf() that the variables that
are parsed by the new code are the ones received in resultstr

b) web100clt -n neubot.mlab.mlab1.mil01.measurement-lab.org that at
the moment is running botticelli v0.0.5 (which is buggy and doesn't
send any MSG_RESULTS messages) and make sure it does not crash

c) web100clt -n neubot.mlab.mlab1.trn01.measurement-lab.org that at
the moment is running botticelli v0.0.6 (which sends a single
dummy variable not considered by NDT) and make sure it doesn't crash

Note that a) and c) did not changed after this patch. What this patch
changes is the behavior in case b).

xref: neubot/botticelli#18.


Commit: 70ff8bc5ea8efb89e38801ca203db43b1f5566d3

https://github.com/ndt-project/ndt/commit/70ff8bc5ea8efb89e38801ca203db43b1f5566d3
Author: Peter Boothe
<>
Date: 2017-02-17 (Fri, 17 Feb 2017)

Changed paths:
M src/web100clt.c

Log Message:
-----------
Merge pull request #217 from bassosimone/fix/results_parsing

web100clt.c: make results parsing more robust


Compare:
https://github.com/ndt-project/ndt/compare/f3b2ae2d0825...70ff8bc5ea8e

  • [ndt-dev] [ndt-project/ndt] 713766: web100clt.c: make results parsing more robust, GitHub, 02/17/2017

Archive powered by MHonArc 2.6.19.

Top of Page