Skip to Content.
Sympa Menu

ndt-dev - [ndt-dev] [ndt-project/ndt] 4277db: No more freezing if pcap process goes wrong (#51)

Subject: NDT-DEV email list created

List archive

[ndt-dev] [ndt-project/ndt] 4277db: No more freezing if pcap process goes wrong (#51)


Chronological Thread 
  • From: GitHub <>
  • To:
  • Subject: [ndt-dev] [ndt-project/ndt] 4277db: No more freezing if pcap process goes wrong (#51)
  • Date: Wed, 20 Jul 2016 14:52:24 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=github.com; s=mailo; q=dns; h=Sender: Date: From: Reply-To: To: Message-ID: Subject: Mime-Version: Content-Type: Content-Transfer-Encoding; b=uVX/bR/Ftoc6T9qD1JOsiwBoopJhbTSgoEPqBjoKBNi0P7V0apxLTTYOFfkOVUalMg+Drr 5Aic+mDbi91hrTKzz3cYWPHEAVnV8B5pbln8v/xMGc/SfqqCxFfFPOvKel0WNm0Mn5FJqZFc /DwRL90Lsm6pQDRx3jDJd4GD+mToI=

Branch: refs/heads/master
Home: https://github.com/ndt-project/ndt
Commit: 4277db96bd1a20d07269f5498bb8ed9d2f144eeb

https://github.com/ndt-project/ndt/commit/4277db96bd1a20d07269f5498bb8ed9d2f144eeb
Author: Peter Boothe
<>
Date: 2016-05-09 (Mon, 09 May 2016)

Changed paths:
M src/test_c2s_srv.c

Log Message:
-----------
No more freezing if pcap process goes wrong (#51)

If packet capture fails to start for whatever reason, then the whole client
gets hung in a read. When enough clients are hung, then all incoming clients
get queued, and the queue never gets any smaller.

This adds a select() in front of the read() to ensure that the pipe becomes
readable within a second. Thus, if the packet trace is unable to start, the
test can still proceed without it.


Commit: 17ae624626580220c512de1982d0aec2e99fa5e6

https://github.com/ndt-project/ndt/commit/17ae624626580220c512de1982d0aec2e99fa5e6
Author: Peter Boothe
<>
Date: 2016-05-11 (Wed, 11 May 2016)

Changed paths:
M src/test_c2s_srv.c
M src/web100srv.c
M src/web100srv_unit_tests.c

Log Message:
-----------
Three small bugfixes, one of which was causing real issues for MLab servers
in developing nations. (#52)

A one-line compiler wanring fix for test_c2s.
Fixing watchdog timer issues in web100srv. (The server bug)
Making end-to-end unit tests less flaky by no longer just assuming that every
port in the range [1024, 31024) is fine for the server to take as its own.


Commit: f509bb00275191c458eabffc19fb2132dff7aca7

https://github.com/ndt-project/ndt/commit/f509bb00275191c458eabffc19fb2132dff7aca7
Author: nkinkade
<>
Date: 2016-05-12 (Thu, 12 May 2016)

Changed paths:
M HTML5-frontend/Makefile.am

Log Message:
-----------
Update HTML-frontend Makefile to reference new version of jquery. (#53)


Commit: 225d009a5fd34b7b9352912f1ce501038a00bb4e

https://github.com/ndt-project/ndt/commit/225d009a5fd34b7b9352912f1ce501038a00bb4e
Author: Peter Boothe
<>
Date: 2016-06-08 (Wed, 08 Jun 2016)

Changed paths:
M src/Makefile.am
M src/test_c2s_srv.c
M src/test_s2c_srv.c
A src/testutils.c
A src/testutils.h

Log Message:
-----------
S2c freeze fix (#57)

* Three small bugfixes, one of which was causing real issues for MLab servers
in developing nations.
A one-line compiler warning fix for test_c2s.
Fixing watchdog timer issues in web100srv. (The server bug)
Making end-to-end unit tests less flaky by no longer just assuming that every
port in the range [1024, 31024) is fine for the server to take as its own.

* Moved helper functions to testutils, so that they can be used by both c2s
and s2c. Used those new helper functions to fix a freezing error in s2c,
where the s2c test pauses until it hears back from the packet trace
engine, and so if the packet trace engine fails to start, then the s2c
test just freezes forever.

* Updated in response to comments by Josh to eliminate `strlen()`.


Commit: a3a9c4f65f5b4c94435c43decd1be1c541aaafd6

https://github.com/ndt-project/ndt/commit/a3a9c4f65f5b4c94435c43decd1be1c541aaafd6
Author: Peter Boothe
<>
Date: 2016-06-08 (Wed, 08 Jun 2016)

Changed paths:
M src/testoptions.c
M src/web100srv.c

Log Message:
-----------
Valgrind fixes (#59)

* Three small bugfixes, one of which was causing real issues for MLab servers
in developing nations.
A one-line compiler wanring fix for test_c2s.
Fixing watchdog timer issues in web100srv. (The server bug)
Making end-to-end unit tests less flaky by no longer just assuming that every
port in the range [1024, 31024) is fine for the server to take as its own.

* One cleanup to an assert, and one fix that alleviates a crashing bug.

* Changes in response to valgrind worrying about uninitialized values and
unsafe uses of pthread functions.

* One cleanup to an assert, and one fix that alleviates a crashing bug.

* Changes in response to valgrind worrying about uninitialized values and
unsafe uses of pthread functions.


Commit: 08e82d95ebc01fb759185ceeebfca060ae4a996f

https://github.com/ndt-project/ndt/commit/08e82d95ebc01fb759185ceeebfca060ae4a996f
Author: Peter Boothe
<>
Date: 2016-06-14 (Tue, 14 Jun 2016)

Changed paths:
M src/network.c
M src/testoptions.c
M src/web100srv.c
M src/web100srv.h
M src/websocket.c

Log Message:
-----------
Fix ssl accept (#60)

* SSL_accept no longer fails so much. This brings wss reliability up to ws
reliability.

This PR moves all accept()ing of the incoming socket into the child process.

* Cleanup of error-handling code.


Commit: 93976a3aeea92e91d1290dedd5fdf521ebc7e43c

https://github.com/ndt-project/ndt/commit/93976a3aeea92e91d1290dedd5fdf521ebc7e43c
Author: Peter Boothe
<>
Date: 2016-07-20 (Wed, 20 Jul 2016)

Changed paths:
M HTML5-frontend/Makefile.am
M src/Makefile.am
M src/network.c
M src/test_c2s_srv.c
M src/test_s2c_srv.c
M src/testoptions.c
A src/testutils.c
A src/testutils.h
M src/web100srv.c
M src/web100srv.h
M src/web100srv_unit_tests.c
M src/websocket.c

Log Message:
-----------
Merge pull request #210 from m-lab/master

Increase robustness in the face of partial failures, and improve error logging


Compare:
https://github.com/ndt-project/ndt/compare/5e98f1a4695b...93976a3aeea9

  • [ndt-dev] [ndt-project/ndt] 4277db: No more freezing if pcap process goes wrong (#51), GitHub, 07/20/2016

Archive powered by MHonArc 2.6.19.

Top of Page