NDT-DEV email list created

Comment #4 on issue 139 by : Clean up and  
modularize the NDT server codebase
http://code.google.com/p/ndt/issues/detail?id=139

From Aaron's mail:

My preference would be to focus on code readability, and to clean up the  
web100 handling a bit as part of that. The main web100srv.c is almost  
unreadable. It'd be good to try to separate out the 'child' handling from  
the test scheduling, and the 'parent' handling. As a simple example, the  
single 'cleanup' function that handles all signals for all processes, no  
matter what, makes no sense. The amount of 'global' variables needs to be  
pared back considerably to ensure that the logic of the workflow is more  
straight-forward.

Related to that, it'd be nice to modularize the web100/10g work to make it  
cleaner, especially for including things like tcp_info. e.g. have the test  
functions fill out generic tcp statistics that are opaque to the "child"  
handler, and have some functions that take the generic tcp statistics  
objects from the tests, and based on web10g, web100, or tcp_info, fill out  
the NDT expected response values (e.g. the c2sspd variable)

I'm vaguely envisioning something like:

foreach test in tests_to_perform():
    test.results = run_test(test)

ndt_results = build_ndt_results(tests)

I'm envisioning that ndt_results object would have all the individual  
elements

The build_ndt_results function then might look like:

     results.rtt = calculate_rtt(tests['s2c_results'])

and then the protocol handling takes that "results" object, and spits it  
out.

--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings