NDT-DEV email list created

Comment by 
:

Line-by-line comments:

File: /branches/FlashIssue117/flash-client/src/GUI.as (r955)
===============================================================================

Line 329:         if (TestResults.getErrMsg() != "") {
-------------------------------------------------------------------------------
Indentation non correct. Please, fix.
Line 330:         _summaryResultText += "There were some errors during  
tests:<br>"
-------------------------------------------------------------------------------
I'd suggest to replace
"during tests"
with
"during the test"
because the previous line in the result tab says "NDT test run ... "
File: /branches/FlashIssue117/flash-client/src/TestResults.as (r955)
===============================================================================

Line 83:       _errMsg += "<font color=\"#FE9A2E\"><b>" + msg  
+ "</b></font>" + "\n";
-------------------------------------------------------------------------------
I suggest have all the formatting code in GUI.as.
Namely, I suggest the following changes:

in src/TestResults.as
public static function appendErrMsg(msg:String):void {
  _errMsg += msg + "\n";
  NDTUtils.callExternalFunction("appendErrors", msg);
  appendDebugMsg(msg);
}

in src/GUI.as
if (TestResults.getErrMsg() != "") {
  _summaryResultText += "There were some errors during the tests:<br>"
                                        + "<font color=\"#CC3333\"><b>" +  
TestResults.getErrMsg() + "</b></font>" + "\n";


Line 85:       appendDebugMsg("<font color=\"#FE9A2E\"><b>" + msg  
+ "</b></font>");
-------------------------------------------------------------------------------
#FE9A2E is very difficult to read.
I suggest to use #CC3333 instead.

For more information:
https://code.google.com/p/ndt/source/detail?r=955