Skip to Content.
Sympa Menu

ndt-dev - [ndt-dev] Comment on revision r927 in ndt

Subject: NDT-DEV email list created

List archive

[ndt-dev] Comment on revision r927 in ndt


Chronological Thread 
  • From:
  • To:
  • Subject: [ndt-dev] Comment on revision r927 in ndt
  • Date: Tue, 18 Feb 2014 09:01:18 +0000

Comment by
:

Line-by-line comments:

File: /branches/FlashIssue112/flash-client/src/GUI.as (r927)
===============================================================================

Line 78: _aboutNDTText.text = Main.NDT_description == null ?
-------------------------------------------------------------------------------
Use directly Main.ndt_description, which is always initialized.
Similarly to line 250.
File: /branches/FlashIssue112/flash-client/src/Main.as (r927)
===============================================================================

Line 29: public static var NDT_description:String = NDTConstants.NDT_DESCRIPTION;
-------------------------------------------------------------------------------
Lower case.
Upercase is for constants.
File: /branches/FlashIssue112/flash-client/src/NDTUtils.as (r927)
===============================================================================

Line 94:
-------------------------------------------------------------------------------
Line with white spaces.
To avoid this in all the files that you edit, could you configure yr editor to strip out white spaces at the end of the line?
Line 98: "Initialized description from JavaScript.");
-------------------------------------------------------------------------------
I would add the string ndt_description to the debug message.
Also, just "description" is very generic. I suggest:
s/description/NDT description/

For more information:
https://code.google.com/p/ndt/source/detail?r=927


  • [ndt-dev] Comment on revision r927 in ndt, ndt, 02/18/2014

Archive powered by MHonArc 2.6.16.

Top of Page