Skip to Content.
Sympa Menu

ndt-dev - [ndt-dev] Comment on revision r910 in ndt

Subject: NDT-DEV email list created

List archive

[ndt-dev] Comment on revision r910 in ndt


Chronological Thread 
  • From:
  • To:
  • Subject: [ndt-dev] Comment on revision r910 in ndt
  • Date: Fri, 14 Feb 2014 10:50:05 +0000

Comment by
:

Line-by-line comments:

File: /branches/FlashIssue116/flash-client/src/NDTPController.as (r910)
===============================================================================

Line 231: TestResults.appendDebugMsg("<font color=\"#006400\">" + "All the tests completed successfully." + "</font>");
-------------------------------------------------------------------------------
Could you split this line into two, to make sure that the max line length is <= 80?
Also, #006400 is very difficult to read on a green background.
File: /branches/FlashIssue116/flash-client/src/TestC2S.as (r910)
===============================================================================

Line 426: + " test <font color=\"#006400\"><b>" + ResourceManager.getInstance().getString(
-------------------------------------------------------------------------------
006400 is very difficult to read on the green background.
Maybe you could use a much lighter green?
Line 431: NDTConstants.BUNDLE_NAME, "c2sThroughputFailed", null, Main.locale) + "</font>");
-------------------------------------------------------------------------------
Could you split this line into two, with max line length 80?
File: /branches/FlashIssue116/flash-client/src/TestResults.as (r910)
===============================================================================

Line 92: var formattedMsg:String = "<font size=\"12\">" + (new Date().toUTCString()) + ": " + "</font>" + msg + "\n";
-------------------------------------------------------------------------------
Could you split this line into 2, with max line length 80?
File: /branches/FlashIssue116/flash-client/src/TestS2C.as (r910)
===============================================================================

Line 498: NDTConstants.BUNDLE_NAME, "s2cThroughputFailed", null, Main.locale) + "</font>");
-------------------------------------------------------------------------------
Could you split this line into 2, with max line length 80?

For more information:
https://code.google.com/p/ndt/source/detail?r=910


  • [ndt-dev] Comment on revision r910 in ndt, ndt, 02/14/2014

Archive powered by MHonArc 2.6.16.

Top of Page