ndt-dev - [ndt-dev] Comment on revision r903 in ndt
Subject: NDT-DEV email list created
List archive
- From:
- To:
- Subject: [ndt-dev] Comment on revision r903 in ndt
- Date: Fri, 14 Feb 2014 10:26:19 +0000
Comment by
:
Line-by-line comments:
File: /branches/FlashIssue113/flash-client/src/GUI.as (r903)
===============================================================================
Line 55: private var _restartButton:Sprite;
-------------------------------------------------------------------------------
AFAICT, in all yr changes, you have tabs instead of white spaces, which results in lack of alignment with previous code.
Could you replace all the tabs with white spaces?
Line 250: _restartButton.y = CONFIG::debug ? _debugButton.y + 1.5 * verticalMargin : _errorsButton.y + 1.5 * verticalMargin;
-------------------------------------------------------------------------------
I have tried to keep the line length to max 80 characters.
Could you split this line into 2?
Also, the y of this button is too distant from the previous one.
I think the correct formula should be:
_restartButton.y = CONFIG::debug ? _debugButton.y + verticalMargin : _errorsButton.y + verticalMargin;
Line 371:
-------------------------------------------------------------------------------
Line with white spaces (?)
File: /branches/FlashIssue113/flash-client/src/TestResults.as (r903)
===============================================================================
Line 146:
-------------------------------------------------------------------------------
Nit: White spaces.
Line 164: remoteTestResults = "";
-------------------------------------------------------------------------------
You should also set c2sTestSuccess and s2cTestSuccess to false.
For more information:
https://code.google.com/p/ndt/source/detail?r=903
- [ndt-dev] Comment on revision r903 in ndt, ndt, 02/14/2014
Archive powered by MHonArc 2.6.16.