NDT-DEV email list created

Status: New
Owner: ----
Labels: Type-Defect Severity-Medium

New issue 101 by : NDTConstants.SRV_QUEUE_TEST_STARTS_NOW  
misplaced in the Java client.
http://code.google.com/p/ndt/issues/detail?id=101

By comparing line 2412  
(https://code.google.com/p/ndt/source/browse/trunk/Applet/Tcpbw100.java#2412)  
with other similar parts of the code (e.g.,  
https://code.google.com/p/ndt/source/browse/trunk/Applet/Tcpbw100.java#2494),  
it seems to me that
line 2412 should use
NDTConstants.PROTOCOL_MSG_READ_SUCCESS
instead of
NDTConstants.SRV_QUEUE_TEST_STARTS_NOW

On the other hand, NDTConstants.SRV_QUEUE_TEST_STARTS_NOW should be used at  
line  
https://code.google.com/p/ndt/source/browse/trunk/Applet/Tcpbw100.java#2437.

Note that the changes that I am proposing

1) are consistent with the implementation of the c client.
See https://code.google.com/p/ndt/source/browse/trunk/src/web100clt.c#671  
and https://code.google.com/p/ndt/source/browse/trunk/src/web100clt.c#691

2) would not change the behavior of the Java client in any way, because  
NDTConstants.PROTOCOL_MSG_READ_SUCCESS ==  
NDTConstants.SRV_QUEUE_TEST_STARTS_NOW == 0.

Could you confirm if my suggestions make sense or if I simply misread the  
code?


--
You received this message because this project is configured to send all  
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings