Skip to Content.
Sympa Menu

ndt-dev - [ndt-dev] Re: Issue 67 in ndt: Patch review for issues 62, 63, 64, and Commit Request

Subject: NDT-DEV email list created

List archive

[ndt-dev] Re: Issue 67 in ndt: Patch review for issues 62, 63, 64, and Commit Request


Chronological Thread 
  • From:
  • To:
  • Subject: [ndt-dev] Re: Issue 67 in ndt: Patch review for issues 62, 63, 64, and Commit Request
  • Date: Wed, 07 Nov 2012 17:43:40 +0000


Comment #1 on issue 67 by : Patch review for issues 62, 63, 64, and Commit Request
http://code.google.com/p/ndt/issues/detail?id=67

Line numbers refer to patch line numbers rather than code line numbers.

46/47: Don't reverse the check here. Having the constant first is a simple way to protect against the = vs == typo.

86: worth logging when intent is null? Actually, it might be better to just return if intent == null and not even try to set any text views.

266: indent changed
273: indent changed
282: indent changed
289: indent changed
298: indent
305: indent
314: indent
321: indent
330: indent
337: indent
346: indent
353: indent
362: indent
378: indent
385: indent
etc etc etc :)






Archive powered by MHonArc 2.6.16.

Top of Page