OpenSAML user discussion

["Clifford Johnson" <>]

The only test case in this class fails with the following details:

 

org.opensaml.saml1.binding.encoding.HTTPPostEncoderTest#testEncoding

 

junit.framework.ComparisonFailure: Unexpected content type expected:<application/xhtml+x...> but was:<text/ht...>

    at org.opensaml.saml1.binding.encoding.HTTPPostEncoderTest.testEncoding(HTTPPostEncoderTest.java:81)

 

The test case is expecting the Content-Type to be “application/xhtml+xml” but org.opensaml.saml1.binding.encoding.HTTPPostEncoder#postEncode sets the Content-Type to a constant “text/html” which doesn’t seem quite right – I don’t know the circumstances under which [saml1] HTTPPostEncoder is used but I’d think the Content-Type value should probably be obtained from the Velocity template in some way since it’s the template content that would govern the proper value.  In the test case, the template seems to be an XHTML document.

 

Is a hard-coded value in HTTPPostEncoder appropriate?  Since the class is Velocity template driven, is there some way to derive the proper type from the template (or resulting document)?

 

Clifford