grouper-users - [grouper-users] Patch: Fix PSPNG log entries

Subject: Grouper Users - Open Discussion List

List archive

[grouper-users] Patch: Fix PSPNG log entries

From: "Morgan, Andrew Jason" <>
To: "" <>
Subject: [grouper-users] Patch: Fix PSPNG log entries
Date: Fri, 7 Feb 2020 17:49:03 +0000
Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oregonstate.edu; dmarc=pass action=none header.from=oregonstate.edu; dkim=pass header.d=oregonstate.edu; arc=none
Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QNLjE0KxXd64EKFZ6y1QuZFfjPPg9Q2c42LunWQvBXY=; b=DXm0pfaksZzTgSr3kDwphOozs6BuEqO49pKnnLZ7fsyctGOr+J62iecBZHuwGu/K2x6n6QbTQQbpKtnIbhzT2cOjsddK7EQLp69MZ/K7pQfu166STus2jAFUfVAEsYJrjwHHFI4uZjie1pdOV52qdZN9LIi5VGOHD3aucLS/7E6pURtA4O3tWxupN+G6Vl5YuYoCkcBhu+dsgdabvKEGvqcRKFr59rnd/YNNNN8RTos6/GkHLTFk/LebCGOh3o7C/+lq4qtionT2ThhEYBy+NBopkPJsrv0yQKgQo1omuN1cYZtzVAfsNDl8Mvwkb58katJz8NLfsvwbRxXEx8qUlQ==
Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Oe+wF7hVCqWINkOk+HdPPkbnMzCtPvalua/rJRVTh8xngoSCJ+R6nmiXFALVayY6ZPPk0ytIBGVyrg06AYQdUd74ui+0iYP8tloH32UXwZvCgjFxWHTVcM62leoerujZnt+tU3Dh6BkWV1ZYFrA7jIVO6SDrCeRcjwl1t0k1J2g1bxEYFJVxCCNQFJnmenlN7Q2Z37o9ZXAF5m6eMMXh+M7zro1PVMNIytE8eU+24bdyAWKLq/aFj8gDy18y6x+LPljLJYvzxyMtMRn+cMSf64cb4sMt7aYST4Zyk9mcCQM6KEzfccRvCtQuAOibR9sKxR97K3HoAhneo1ei4bRjuQ==

I have attached a patch that fixes a small number of log statements that have an unbalanced number of parameters. This is a diff against the master branch.

Let me know if you have any questions.

Thanks,

Andy

--- Provisioner.java.orig	2020-02-07 09:33:27.056252214 -0800
+++ Provisioner.java	2020-02-07 09:45:46.139741165 -0800
@@ -1319,8 +1319,8 @@
     // Save updated list of groups selected for provisioner
     selectedGroups.set(selectedGroups_now);
 
-    LOG.info("{}: Change deselected {} groups from provisioner", deselectedGroups.size());
-    LOG.info("{}: Change selected {} new groups for provisioner", newlySelectedGroups.size());
+    LOG.info("{}: Change deselected {} groups from provisioner", getDisplayName(), deselectedGroups.size());
+    LOG.info("{}: Change selected {} new groups for provisioner", getDisplayName(), newlySelectedGroups.size());
 
     for (GrouperGroupInfo group : deselectedGroups) {
       TSGroupClass tsGroup=null;
@@ -1331,12 +1331,12 @@
           continue;
         }
       }
-      LOG.info("{}: Deleting group from target system because it is no longer selected for provisioning: {}", group);
+      LOG.info("{}: Deleting group from target system because it is no longer selected for provisioning: {}", getDisplayName(), group);
       deleteGroup(group, tsGroup);
     }
 
     for (GrouperGroupInfo group : newlySelectedGroups) {
-      LOG.info("{}: Scheduling full sync of group because it is now selected for provisioning: {}", group);
+      LOG.info("{}: Scheduling full sync of group because it is now selected for provisioning: {}", getDisplayName(), group);
 
       getFullSyncer().scheduleGroupForSync(
               FullSyncProvisioner.QUEUE_TYPE.CHANGELOG,
@@ -1769,7 +1769,7 @@
       if ( shouldGroupBeProvisioned(grouperGroupInfo) )
         result.add(grouperGroupInfo);
     }
-    LOG.info("{}: There are {} groups selected for provisioning (found in %s)",
+    LOG.info("{}: There are {} groups selected for provisioning (found in {})",
         getDisplayName(), result.size(), PspUtils.formatElapsedTime(start, null));
 
     return result;

[grouper-users] Patch: Fix PSPNG log entries, Morgan, Andrew Jason, 02/07/2020

List archive

[grouper-users] Patch: Fix PSPNG log entries