Grouper Users - Open Discussion List

["Hyzer, Chris" <>]

Chad,

I split out disabling the enter key on dojo combobox to its own jira.

This is fixed in 2.3.0 UI patch #11.  Can you please try it out and let me 
know how it goes?

https://bugs.internet2.edu/jira/browse/GRP-1448

Note, it was implemented a little differently and will not allow enter in any 
dojo combobox. Defaults to on. If you set this in grouper.ui.properties you 
can disable it

grouperUi.disableEnterKeyOnCombobox = false

https://github.com/Internet2/grouper/commit/ebbfada03d3bd6fb0c5358d8acfeb0e22c256e52

https://github.com/Internet2/grouper/commit/62e427027345a18670b958b6534236cfb5c55b1a

Can we close 1440 now too?

Thanks
Chris



-----Original Message-----
From: Chad Redman (JIRA) 
[mailto:]
 
Sent: Thursday, December 15, 2016 12:58 PM
To: Hyzer, Chris 
<>
Subject: [JIRA] (GRP-1440) Usability of the Add Member dojo search field


    [ 
https://bugs.internet2.edu/jira/browse/GRP-1440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=24347#comment-24347
 ] 

Chad Redman commented on GRP-1440:
----------------------------------

I tried out adding the same inner code as that, but in 
_TextBoxMixin->onInput(). That's a wide net, but seems to fix issues in 
add-members-form and add-groups-form. And it doesn't seem to hurt the stem 
field of the new group form, or any of the Lite fields, since the return key 
already didn't submit.

the add groups combo field had a few of the same problems as the add members 
field, but not as bad. You still get an error if you hit enter on a blank 
field or an invalid group. But if you have a valid group path it resolves it 
before submitting. That would be a different way of fixing the add member 
form, if I knew what magic made that happen :)

The folder combo in the new group form was already ok, as it didn't submit 
anything on return.


> Usability of the Add Member dojo search field
> ---------------------------------------------
>
>                 Key: GRP-1440
>                 URL: https://bugs.internet2.edu/jira/browse/GRP-1440
>             Project: Grouper
>          Issue Type: Bug
>          Components: UI
>    Affects Versions: 2.3.0
>         Environment: Chrome 54.0.2840.99; Firefox 50.0.2
>            Reporter: Chad Redman
>            Assignee: Chris Hyzer
>
> 1)
> When entering IDs into the search field for adding users (labeled "Member 
> name or ID"), entering text into the field will activate a spinning 
> throbber on the field. While the cursor is in the text field the throbber 
> never disappears, and there is no drop down of potential matches. However, 
> if you tab out of the field or otherwise lose focus, the field changes to 
> the display name of the found record.
> The search field for adding users is set up as a dojo combo field, similar 
> to the combo search field for groups. But unlike the group search, the user 
> search does not work for partial search-as-you-type results. The dojo logic 
> java class is invoked with a final wildcard on the query. But it then calls 
> UiV2Group.lookup() to search, which looks up subjects by 
> SubjectFinder.findByIdOrIdentifier(). Unless a source Id actually has a 
> wildcard in the name, I think that nothing would be found.
> As far as I can trace the code, it looks like when the field loses focus, 
> it does the same query but without the wildcard. This would explain why 
> moving from the field exposes the desired result.
> I don't know what the fix should be. Dynamic search results for users would 
> be nominally useful, although it would only be on the Id or Identifier (not 
> a person's full name string, as the label would suggest). But wildcard 
> queries might put a strain on LDAP servers or SQL databases. Maybe the 
> optimal fix is to disable partial dynamic search results.
> 2) After input of a user's id, hitting enter instead of tab has 
> inconsistent behavior depending on prior actions.
>   - initially, it will change to the display name, but then flash an error 
> "Select an entity from the search results"
>   - continuing from above, if another id is entered, the result will be 
> successful, *but it will be the previous ID that is added to the group*!
>   - continuing from the previous entry, hitting return after a third entry 
> will flash the error "Select an entity from the search results"
> Suggested fix: remove carriage return functionality from the add member form
> 3)
> The tooltip that shows up when the field is empty is "Enter 2 or more 
> characters for searching". This would suggest that it is doing a partial 
> search, which isn't functional per #1 above. The wildcard search also 
> happens after the first character, without waiting for the minimal 2 
> characters.
> 4)
> The label for the field is "Member name or ID". But the search is actually 
> on Id or Identifier, not the name attribute or some variation on the user's 
> display name.
> Suggested fix: change base property groupSearchMemberOrId in 
> grouperText/grouper.text.en.us.base.properties to "Member ID or unique 
> identifier"



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)