Grouper Users - Open Discussion List

[Chris Hyzer <>]

There were some problems with some of the less used features of the New UI, though I think it is important to apply the two patches to get it fixed.

 

https://bugs.internet2.edu/jira/browse/GRP-1112

GRP-1112: problems with 'edit memberships and privileges' button

 

Problems are:

1.       If you edit a membership start/end date, it deletes privs for that user on that group

2.       Some buttons show up when they shouldn’t (e.g. Add member button when user doesn’t have UPDATE, though that button will throw an error if used)

a.       Similarly the delete member controls should only show for UPDATE (again, clicking it causes an error if no UPDATE which is good)

3.       Members that are groups that the user cant VIEW show up in member list as blank, instead of a descriptive message

4.       Users should be able to have UPDATE only in the UI

5.       Context menus on the group should show items only when allowed to use them

6.       Users with READ should be able to trace in indirect membership

 

There is a comprehensive test case in the jira that I have tested.   I put this patch on the demo server and tested again so it should be good to go.  Note, it is listed as high risk since it is not a one liner that can easily be configured to not be used, there are a bunch of changes, but I don’t expect there to be any problems with it J

 

Commits:

 

https://github.com/Internet2/grouper/commit/c8cf235ef60ab39e3d7b506494045aa64c8da571

https://github.com/Internet2/grouper/commit/ebdc242d3f352a890b08ed3aec4a8e31a6d497bc

https://github.com/Internet2/grouper/commit/d65732f904256f1f2dcdc8647d76bcf4f6f51eb8

 

Patches:

 

grouper_v2_2_1_api_patch_5

grouper_v2_2_1_ui_patch_9

 

Thanks,

Chris

 

Ps. Example of installing patches:

 

[appadmin@i2midev1 patches]$ java -jar grouperInstaller.jar

Do you want to 'install' a new installation of grouper, 'upgrade' an existing installation

  or 'patch' an existing installation

  (enter: 'install', 'upgrade', 'patch' or blank for the default) [install]: patch

Enter in a Grouper temp directory to download tarballs (note: better if no spaces or special chars) [/opt/grouper/2.2/patches]:

What do you want to patch?  api, ui, ws, or psp? [api]: ui

Where is the grouper UI installed? /opt/tomcats/tomcat_d/webapps/grouper_v2_2

What do you want to do with patches (install, revert, status)? [install]:

 

################ Checking patch grouper_v2_2_1_api_patch_0

Patch: grouper_v2_2_1_api_patch_0: was applied on: 2015/01/18 17:45:34

 

 

################ Checking patch grouper_v2_2_1_api_patch_1

Patch: grouper_v2_2_1_api_patch_1: was applied on: 2015/01/18 17:46:04

 

 

################ Checking patch grouper_v2_2_1_api_patch_2

Patch: grouper_v2_2_1_api_patch_2: was applied on: 2015/01/18 17:46:24

 

 

################ Checking patch grouper_v2_2_1_api_patch_3

Patch: grouper_v2_2_1_api_patch_3: was applied on: 2015/01/20 06:07:54

 

 

################ Checking patch grouper_v2_2_1_api_patch_4

Patch: grouper_v2_2_1_api_patch_4: was applied on: 2015/02/04 13:56:11

 

 

################ Checking patch grouper_v2_2_1_api_patch_5

Patch: grouper_v2_2_1_api_patch_5: was reverted on: 2015/02/23 19:44:16

 

Downloading from URL: http://software.internet2.edu/grouper/release/2.2.1/patches/grouper_v2_2_1_api_patch_5.tar.gz to file: /opt/grouper/2.2/patches/grouper_v2_2_1_api_patch_5.tar.gz

Unzipping: /opt/grouper/2.2/patches/grouper_v2_2_1_api_patch_5.tar.gz

Expanding: /opt/grouper/2.2/patches/grouper_v2_2_1_api_patch_5.tar

Patch grouper_v2_2_1_api_patch_5 is high risk, is a security patch

GRP-1112: problems with 'edit memberships and privileges' button

Would you like to install patch grouper_v2_2_1_api_patch_5 (t|f)? [t]:

 

- set property: grouper_v2_2_1_api_patch_5.date from: 2015/02/23 19:44:16 to: 2015/02/23 19:54:20

This patch requires all processes that user Grouper to be stopped.

  Please stop these processes if they are running and press <enter> to continue...

 

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/subject/provider/SubjectImpl.java

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/subject/provider/SubjectImpl.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/subject/SubjectUtils.java

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/subject/SubjectUtils.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$6.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$16.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$15.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$18.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$22.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/membership/MembershipPathGroup$4.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/membership/MembershipPathGroup.java

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/membership/MembershipPathGroup$2.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/membership/MembershipPathGroup$7.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/membership/MembershipPathGroup$3.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/membership/MembershipPathGroup.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/membership/MembershipPathGroup$5.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/membership/MembershipPathGroup$6.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/membership/MembershipPathGroup$1.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/subj/UnresolvableSubject.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/subj/UnresolvableSubject$LazySubjectType.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/subj/UnresolvableSubject.java

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$17.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$3.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$5.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$13.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$14.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/entity/EntitySourceAdapter.java

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/entity/EntitySourceAdapter.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$20.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$4.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$9.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$7.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$2.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group.java

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$11.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$10.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$1.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$12.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$8.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$19.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$21.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/Group$21$1.class

Patch successfully applied: grouper_v2_2_1_api_patch_5

- set property: grouper_v2_2_1_api_patch_5.state from: reverted to: applied

 

 

################ Checking patch grouper_v2_2_1_api_patch_6

Patch doesnt exist yet (not an error): http://software.internet2.edu/grouper/release/2.2.1/patches/grouper_v2_2_1_api_patch_6.tar.gz

 

 

################ Checking patch grouper_v2_2_1_ui_patch_0

Patch: grouper_v2_2_1_ui_patch_0: was applied on: 2015/01/18 17:46:18

 

 

################ Checking patch grouper_v2_2_1_ui_patch_1

Patch: grouper_v2_2_1_ui_patch_1: was applied on: 2015/01/18 17:46:20

 

 

################ Checking patch grouper_v2_2_1_ui_patch_2

Patch: grouper_v2_2_1_ui_patch_2: was applied on: 2015/01/18 17:46:22

 

 

################ Checking patch grouper_v2_2_1_ui_patch_3

Patch: grouper_v2_2_1_ui_patch_3: was applied on: 2015/01/18 18:12:10

 

 

################ Checking patch grouper_v2_2_1_ui_patch_4

Patch: grouper_v2_2_1_ui_patch_4: was applied on: 2015/01/18 17:46:30

 

 

################ Checking patch grouper_v2_2_1_ui_patch_5

Patch: grouper_v2_2_1_ui_patch_5: was applied on: 2015/01/18 17:46:31

 

 

################ Checking patch grouper_v2_2_1_ui_patch_6

Patch: grouper_v2_2_1_ui_patch_6: was applied on: 2015/01/18 19:55:29

 

 

################ Checking patch grouper_v2_2_1_ui_patch_7

Patch: grouper_v2_2_1_ui_patch_7: was applied on: 2015/01/20 06:07:59

 

 

################ Checking patch grouper_v2_2_1_ui_patch_8

Patch: grouper_v2_2_1_ui_patch_8: was applied on: 2015/02/04 13:56:19

 

 

################ Checking patch grouper_v2_2_1_ui_patch_9

Patch: grouper_v2_2_1_ui_patch_9: had an error installing on: 2015/02/23 19:42:48

 

Downloading from URL: http://software.internet2.edu/grouper/release/2.2.1/patches/grouper_v2_2_1_ui_patch_9.tar.gz to file: /opt/grouper/2.2/patches/grouper_v2_2_1_ui_patch_9.tar.gz

Unzipping: /opt/grouper/2.2/patches/grouper_v2_2_1_ui_patch_9.tar.gz

Expanding: /opt/grouper/2.2/patches/grouper_v2_2_1_ui_patch_9.tar

Patch grouper_v2_2_1_ui_patch_9 is high risk, is a security patch

GRP-1112: problems with 'edit memberships and privileges' button

Would you like to install patch grouper_v2_2_1_ui_patch_9 (t|f)? [t]:

 

- set property: grouper_v2_2_1_ui_patch_9.date from: 2015/02/23 19:42:48 to: 2015/02/23 19:54:26

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/grouperUi2/group/groupMoreActionsButtonContents.jsp

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/grouperUi2/group/groupContents.jsp

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/grouperUi2/group/thisGroupsMembershipsContents.jsp

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/grouperUi2/group/thisGroupsGroupPrivilegesContents.jsp

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/grouperUi2/group/groupPrivilegeContents.jsp

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/grouperUi2/group/viewGroup.jsp

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/grouperUi2/membership/editMembership.jsp

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/grouperUi2/subject/subjectContents.jsp

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/grouperUi2/externalEntities/invite.jsp

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/grouperUi/beans/api/GuiObjectBase.java

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/grouperUi/beans/api/GuiMembershipContainer.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/grouperUi/beans/api/GuiSubject.java

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/grouperUi/beans/api/GuiSubject.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/grouperUi/beans/api/GuiSubject$1.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/grouperUi/beans/api/GuiObjectBase.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/grouperUi/beans/api/GuiGroup.class

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/grouperUi/beans/api/GuiGroup.java

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/edu/internet2/middleware/grouper/grouperUi/beans/api/GuiMembershipContainer.java

Applying file: /opt/tomcats/tomcat_d/webapps/grouper_v2_2/WEB-INF/classes/grouperText/grouper.text.en.us.base.properties

Patch successfully applied: grouper_v2_2_1_ui_patch_9

- set property: grouper_v2_2_1_ui_patch_9.state from: error to: applied

 

 

################ Checking patch grouper_v2_2_1_ui_patch_10

Patch doesnt exist yet (not an error): http://software.internet2.edu/grouper/release/2.2.1/patches/grouper_v2_2_1_ui_patch_10.tar.gz

 

Since patches were applied, you should delete files in your app server work directory,

  in tomcat it is named 'work'.  Hit <enter> to continue:

[appadmin@i2midev1 patches]$

 

 

From: Shilen Patel [mailto:]
Sent: Wednesday, February 11, 2015 9:19 AM
To: Chris Hyzer;
Subject: Re: [grouper-core] RE: UI bug or confusion

 

Thanks.  I tried a few things and it looks good to me now.

 

Thanks!

 

- Shilen

 

From: Chris Hyzer <>
Date: Monday, February 9, 2015 at 2:40 PM
To: Shilen Patel <>, "" <>
Subject: RE: [grouper-core] RE: UI bug or confusion

 

Ive got a first pass of this in git, Shilen, want to try some tests?

 

I put some test cases here on the jira

 

https://bugs.internet2.edu/jira/browse/GRP-1112

 

I think I need to make it more complex and make GSH scripts so it is easy to setup the test.

 

Currently the knows issues are:

 

1.      If a user cant view a member group, should give a message instead of unresolvable, e.g. “You cannot view group name”

2.      The Add Member button should not appear of the user does not have UPDATE

3.      Can users UPDATE but not READ with the UI?  Need to test

 

Anything else?  J

 

Thanks

Chris

 

From: Shilen Patel []
Sent: Thursday, February 05, 2015 7:45 PM
To: Chris Hyzer;
Subject: Re: [grouper-core] RE: UI bug or confusion

 

I think you can do it in the api, but yeah I don’t think it’s important.  So removing the links is fine.  Main thing is the privs being deleted.

 

Thanks!

 

- Shilen

 

From: Chris Hyzer <>
Date: Thursday, February 5, 2015 at 7:05 PM
To: Shilen Patel <>, "" <>
Subject: [grouper-core] RE: UI bug or confusion

 

I think we dont have start/end dates in the UI / API / WS right?   Should we add that for 2.3?  I will remove those links in 2.2.1.patch, ok?  I need to look into deleting the privs, that shouldnt happen

 

Thanks,

Chris

 

From: [] On Behalf Of Shilen Patel
Sent: Friday, January 30, 2015 1:53 PM
To:
Subject: [grouper-core] UI bug or confusion

 

Chris,

 

I’m on the privileges tab of a group and I select an existing privilege that’s assigned to a person.  Then I click on Actions -> Edit memberships and privileges.    There are options there for start and end dates.  Since I got to this page from the privileges tab, I thought I would be setting start/end dates for the privilege.  But it looks like it ends up setting it for the membership (and it creates a membership if it doesn’t exist).  Is that intended?  It also deletes the privilege.

 

Thanks!

 

- Shilen