Skip to Content.
Sympa Menu

grouper-dev - RE: [grouper-dev] ChangeLogTypeIdentifier comments?

Subject: Grouper Developers Forum

List archive

RE: [grouper-dev] ChangeLogTypeIdentifier comments?


Chronological Thread 
  • From: "Hyzer, Chris" <>
  • To: "William G. Thompson, Jr." <>, Grouper Dev <>
  • Subject: RE: [grouper-dev] ChangeLogTypeIdentifier comments?
  • Date: Fri, 12 Feb 2016 14:55:04 +0000
  • Accept-language: en-US
  • Authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=isc.upenn.edu;
  • Spamdiagnosticmetadata: NSPM
  • Spamdiagnosticoutput: 1:23

I think this class was copied (sloppily) from AuditTypeIdentifier, so yes,
the work audit should be change log :)

Thanks
Chris

-----Original Message-----
From:


[mailto:]
On Behalf Of William G. Thompson, Jr.
Sent: Thursday, February 11, 2016 10:39 PM
To: Grouper Dev
<>
Subject: [grouper-dev] ChangeLogTypeIdentifier comments?

I'm looking into the changelog consumers and found my way to
ChangeLogTypeIdentifier. The comments in the code seem off, but wanted
to make sure before I submit a pull request.

ChangeLogTypeIdentifier comments mentions use of AuditTypeBuiltin,
audit category, and audit type, but the only implementation is
ChangeLogTypeBuiltin. The comments should be ChangeLogTypeBuiltin,
changelog category, and changelog type, correct?

Best,
Bill
--

package edu.internet2.middleware.grouper.changeLog;

/**
* interface which could be on the enum, or class, or whatever.
* generally you will use the enum AuditTypeBuiltin
*/
public interface ChangeLogTypeIdentifier {

/**
* get the audit category
* @return the id
*/
public String getChangeLogCategory();

/**
* get the action name of the audit type
* @return the name
*/
public String getActionName();

}



Archive powered by MHonArc 2.6.16.

Top of Page