Grouper Developers Forum

[Chris Hyzer <>]

We made the subject attributes case insensitive, which solves a bunch of problems.  I assume no one has to subject api attributes which are the same except for case.  E.g. EMAIL and email which are different attributes. 

 

https://bugs.internet2.edu/jira/browse/GRP-450

 

If implement your own source, and you do not extend SubjectImpl and BaseSourceAdaptor, then you need to make the following changes: all the Subject attribute methods are case-insensitive, you should use the SubjectCaseInsensitiveMap for attributes. The source attribute names should be toLowerCase, you should use the SubjectCaseInsensitiveSet for the Source attribute names.

 

I added an entry here:

 

https://spaces.internet2.edu/display/Grouper/Grouper+changes+v2.0

 

Shilen, do you mind reviewing my last commit and let me know any feedback.

Thanks,

Chris

 

Ps. only 6 more api unit tests to address…

 

From: Shilen Patel [mailto:]
Sent: Saturday, August 06, 2011 3:25 PM
To: Chris Hyzer;

 

Are you using mysql and if so are the attributes in sources.xml uppercase?  If so, then you're probably hitting this:

 

https://bugs.internet2.edu/jira/browse/GRP-450

 

Should we fix GRP-450 and make attributes case insensitive?  Otherwise, the case would need to change in sources.xml when using mysql and postgres.

 

Thanks!

 

-- Shilen

 

 

From: Chris Hyzer <>
Date: Sat, 6 Aug 2011 19:20:04 +0000
Subject: sort/search col unit tests

 

Shilen,

 

I don’t understand the sort/search col tests, do they require something special in the sources.xml or just the default?

 

Thanks,

Chris

 

Test for edu.internet2.middleware.grouper.member

edu.internet2.middleware.grouper.member.TestMemberAttributes

testNonDefaultSearchAndSort(edu.internet2.middleware.grouper.member.TestMemberAttributes)

junit.framework.ComparisonFailure: null expected:<...ame is test.subject.[2]> but was:<...ame is test.subject.[1]>

                at junit.framework.Assert.assertEquals(Assert.java:81)

                at junit.framework.Assert.assertEquals(Assert.java:87)

                at edu.internet2.middleware.grouper.member.TestMemberAttributes.testNonDefaultSearchAndSort(TestMemberAttributes.java:1018)

                at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

                at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)

                at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

                at java.lang.reflect.Method.invoke(Method.java:597)

                at junit.framework.TestCase.runTest(TestCase.java:168)

                at junit.framework.TestCase.runBare(TestCase.java:134)

                at junit.framework.TestResult$1.protect(TestResult.java:110)

                at junit.framework.TestResult.runProtected(TestResult.java:128)

                at junit.framework.TestResult.run(TestResult.java:113)

                at junit.framework.TestCase.run(TestCase.java:124)

                at junit.framework.TestSuite.runTest(TestSuite.java:232)

                at junit.framework.TestSuite.run(TestSuite.java:227)

                at junit.framework.TestSuite.runTest(TestSuite.java:232)

                at junit.framework.TestSuite.run(TestSuite.java:227)

                at junit.framework.TestSuite.runTest(TestSuite.java:232)

                at junit.framework.TestSuite.run(TestSuite.java:227)

                at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:79)

                at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:46)

                at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)

                at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:467)

                at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:683)

                at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:390)

                at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:197)