Grouper Developers Forum

[Tom Zeller <>]

Chris,

To make sure I understand, are you saying that instead of :

 group.grantPriv(attrDef, subject);

the API will be

 attributeDef.grantPriv(subject, group);

? And that this way, the group object will have less (new) methods ?


TomZ

> ## API delegates to organize API
>
> One of the concerns with the attribute framework and privilege management 
> was that it would bloat the API.  I think the current strategy the API uses 
> for one-to-many methods in the API (just add all methods to the "one" 
> object), is the cause for the bloat.  The Group object currently has 
> thousands of lines of code, and hundreds of methods.  However, if we 
> organized the methods by one-to-many (or other means), then it would be a 
> lot easier to use / maintain / test / etc.  i.e. look at the privilege 
> assignment above:
>
> attributeDef.getPrivilegeDelegate().grantPriv(SubjectTestHelper.SUBJ0, 
> AttributeDefPrivilege.ATTR_ADMIN, false);
>
> In the Group object (and note I am not changing existing API here, this is 
> for new stuff), all the privilege methods are in the group object.  
> However, above you see that I am putting them in another class which exists 
> to delegate logic from the "one" class, to the "many" class (in this case 
> privileges).  I will use this technique for attributes and permission 
> management as well, and we will not see any bloat.  You will notice that 
> the resulting API object model does not mirror the data model... oh well.