comanage-dev - Re: [comanage-dev] policy/procedure on GitHub pull requests from outside project
Subject: COmanage Developers List
List archive
Re: [comanage-dev] policy/procedure on GitHub pull requests from outside project
Chronological Thread
- From: Benn Oshrin <>
- To:
- Subject: Re: [comanage-dev] policy/procedure on GitHub pull requests from outside project
- Date: Mon, 15 Jan 2018 14:50:22 -0500
- Ironport-phdr: 9a23:yx3TqhQnFip072g+Jtzxwpfqv9psv+yvbD5Q0YIujvd0So/mwa69YhaN2/xhgRfzUJnB7Loc0qyK6/mmATRIyK3CmUhKSIZLWR4BhJdetC0bK+nBN3fGKuX3ZTcxBsVIWQwt1Xi6NU9IBJS2PAWK8TW94jEIBxrwKxd+KPjrFY7OlcS30P2594HObwlSizexfa5+IA+qoQnNq8IbnZZsJqEtxxXTv3BGYf5WxWRmJVKSmxbz+MK994N9/ipTpvws6ddOXb31cKokQ7NYCi8mM30u683wqRbDVwqP6WACXWgQjxFFHhLK7BD+Xpf2ryv6qu9w0zSUMMHqUbw5Xymp4qF2QxHqlSgHLSY0/nzJhMx+jKxVoxyvqBJwzIHWfI6bO+Fzfr/fcN4AWWZNQshcWi5HD4ihb4UPFe0BPeNAooTguVQOqx2+DhS1CuP0yj9InH723asn2OkmCg7JwgogH9QJsHnPrdX1MrsSXv6vzKnO0zrDc+1a1S3j54fVbxAsuPeBVq9zf8rJ0UQjCR/Jg1aKpYHhPT6ZzPkBvmaF4+Z6S+6jl20qpxlsrjSzxcogkIfEip4Pxlza6Cl13pw5KcO3RUN5Z9OvDYFeuDuAN4RsR8MvW2Fotzg+yr0BoZO7fC8KyJEmxxHBbvyIaYmI4hb6WOmLIjp0nn1ldKiiiBao70ev0Oj8Vsmz0FZRsipJiMXDtncI1xDL68iHTOVy/lu51DqRywze6ftILEQ2mKbBNpIszKA8moANvUjfHSL6gED2g7WXdkUg9Oio8ePnYrD+q5CHKYB0jAf+MqM1l8y+B+Q4LhYBX3Kd+euiyL3v41f1T6tXgf0riqXZqozVJdwHpq6lBA9Yypos6xG6Dzi81tQXh3YHI0xcdB2akYfpJUrDIPT5Dfekn1Ssiylny+rHPr3nHpXCMGLDkLH/crZh9UJQ0hQ8ws1C58EcNrZUK/X2U0n4u9GdAhInGw2y3+v9DthhjMUTVX/cLLWeNfb4vFmOrsU0I/ONYsdBsjv7Lf8N5vjygGU/lENHO6SlwM1EOziDAv16LhDBMjLXidAbHDJSsw==
If it's a trivial fix, I'd probably just accept the pull request.
If it's non-trivial, there should be a JIRA and the contributor needs to
have signed a CLA of some form.
On 1/15/18 12:55 PM, Scott Koranda wrote:
> Hi,
>
> Do we have a policy/procedure on handling GitHub pull requests from
> people outside of the project?
>
> For example, is it required that we create a matching JIRA and then
> ammend the commit log to include the JIRA number as we would normally do
> with our standard workflow?
>
> Or if the pull request is (a) correct and (b) against the correct branch
> can we just accept (and merge) it?
>
> Thanks,
>
> Scott
>
- [comanage-dev] policy/procedure on GitHub pull requests from outside project, Scott Koranda, 01/15/2018
- Re: [comanage-dev] policy/procedure on GitHub pull requests from outside project, Benn Oshrin, 01/15/2018
Archive powered by MHonArc 2.6.19.