COmanage Developers List

[Benn Oshrin <>]

I patched demo and that fixed issue #1, guess I missed the second path
comparison to update.

I tried double quotes for issue #2 but no dice :)

Thanks,

-Benn-

On 8/22/15 4:40 PM, Arlen Johnson wrote:
> Ok ... I've looked at issue #2 (why the help button href is not being
> populated).  I agree that the config file looks ok.  Just to be sure I
> understood where this was set, I de-minified idpselect.js (which didn't
> make it that much easier to read) - and the href is set in the third
> line below:
> 
> var t = function(az) {
>         var ay = document.createElement("a");
>         ay.href = J;
>         ay.appendChild(document.createTextNode(w("helpText")));
>         Z(ay, "HelpButton");
>         az.appendChild(ay)
>     };
> 
> ...which should be fine, so long as J is set, and it seems to be when I
> trace backwards (though I didn't do this all /that/ carefully).
> 
> I tried looking at a few other EDS pages, but none exposed the help link
> (that I saw ...only looked at two), so Scott would be better on this.  
> Maybe there's a known issue. 
> 
> I suppose you could try wrapping the string in double quotes...  :P
> 
> A
> 
> 
> On 8/22/15 3:39 PM, Arlen Johnson wrote:
>> Ok - committed as of 3e015db.  (I just updated the path.)  The dialog
>> is now hidden.
>>
>> I'll look more closely at the second issue.
>>
>> Arlen
>>
>> On 8/22/15 3:32 PM, Arlen Johnson wrote:
>>> Ah - you did the one above, but not the lower one that shuts off the
>>> dialog.  I'll commit that one back.
>>>
>>> It would probably be better to set a view variable in the Pages
>>> controller and test for that, but if that doesn't go quickly I'll
>>> just fix the path.
>>>
>>> A
>>>
>>> On 8/22/15 3:20 PM, Benn Oshrin wrote:
>>>> Fyi I thought I already pushed the updated conditional...
>>>>
>>>> On August 22, 2015 3:07:28 PM EDT, Arlen Johnson 
>>>> <>
>>>> wrote:
>>>>
>>>>     Ok - the first issue is pretty straightforward and is an easy fix:
>>>>
>>>>     Because the EDS requires a significant amount of javascript in its 
>>>>     library, we turned off other libraries when it is in use, including 
>>>>     jquery.  So the dialog box that would normally be hidden by turning 
>>>> it 
>>>>     into a jquery "dialog" is appearing as normal html.  The text "Are 
>>>> you 
>>>>     sure you wish to proceed" is part of that html block.  So, there's 
>>>> no 
>>>>     actual javascript error: the dialog should probably be hidden 
>>>> instead.
>>>>
>>>>     I think, in fact, we tested for this in default.ctp after the first 
>>>>     changes, and it probably got re-exposed after the update since the 
>>>>     conditional would no longer match.
>>>>
>>>>     ...Confirmed:
>>>>
>>>>     <?php if($this->here != 
>>>>     '/registry/shibboleth_embedded_discovery_service/eds/view'):
>>>>     // Don't load the following UI component when loading the Shib EDS. 
>>>> ?>
>>>>            <div id="dialog"
>>>>     title="Confirm">
>>>>
>>>>     I can fix this if you like.  :-)
>>>>
>>>>     ...Looking at the second issue now.
>>>>
>>>>     Arlen
>>>>
>>>>     On 8/22/15 2:47 PM, Benn Oshrin wrote:
>>>>
>>>>         The first is the "Are you sure you wish to proceed?" text.
>>>>         This is usually indicative of a JavaScript error in the
>>>>         document, and the interpreter aborting before the end of the
>>>>         file (where the div with that text gets hidden). But the
>>>>         only message I can see is "Synchronous XMLHttpRequest on the
>>>>         main thread is deprecated because of its detrimental effects
>>>>         to the end user's experience. For more help,
>>>>         checkhttp://xhr.spec.whatwg.org/."; which is a warning, not
>>>>         an error, and I see the same message on other servers where
>>>>         this is not a problem. 
>>>>
>>>>
>>>
>>
>