COmanage Developers List

[Arlen Johnson <>]

btw - I see that the other commits I made after the pull request got pulled as well ... so you have the more recent changes.  

A

On Sun, May 18, 2014 at 1:15 PM, Arlen Johnson <> wrote:

I did - and it crossed my mind to remove it prior to commit; I held off for a moment thinking I might still use it.  But I'll keep it clean, and re-add if I need to.  (-:

Also - thanks for the heads up on resolve vs. close - I'll follow the practice.

A

On 5/18/2014 7:15 AM, Benn Oshrin wrote:

You seem to have added a language key 'ct.co_people.se.select' that doesn't actually get used? I merged anyway but if you're not planning to use this we should remove it.

I'll ask TSG about commit access tomorrow.

Thanks,

-Benn-

On 5/17/14 7:05 AM, Arlen Johnson wrote:

I just closed this ticket - and the change (and other stylistic updates
to the enrollment flow and enrollment forms) is committed to my fork. At
this late hour, I'm not entirely certain how to add new commits to my
existing pull request  ...and github is not allowing me to create a new
one. So, rather than spend too much time on it, I'll wait until the
first request is pulled and then create another.

I should probably rebase from upstream after these pulls, but I'm ready
to commit to the main branch if your ready to have me there. (Which
will save us the trouble of the pulls, etc.)  (-:

Have a great time in Dublin!

A

On 5/17/2014 1:44 AM, Arlen Johnson (JIRA) wrote:

      [
https://bugs.internet2.edu/jira/browse/CO-722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Arlen Johnson closed CO-722.
----------------------------

     Resolution: Fixed

Approval Email Configuration Hidden on Configuration Page
---------------------------------------------------------

                 Key: CO-722
                 URL: https://bugs.internet2.edu/jira/browse/CO-722
             Project: COmanage
          Issue Type: Bug
          Components: Registry
    Affects Versions: COmanage Registry 0.8.3 (Omnipotent Octagon 33
1/3)
            Reporter: Benn Oshrin
            Assignee: Arlen Johnson
              Labels: NMC
             Fix For: COmanage Registry 0.9 (Essential Enneagon)


When "Notify On Approved Status" is enabled for an enrollment flow
and that enrollment flow is retrieved for editing
(/registry/co_enrollment_flows/edit/x/co:y), "Subject For Approval
Email" and "Approval Email Body" are hidden until "Notify On Approved
Status" is unchecked and rechecked.

--
This message was sent by Atlassian JIRA
(v6.2#6252)