COmanage Developers List

[Scott Koranda <>]

Hi,

Thanks. I pulled those changes.

Scott

On Tue, Sep 24, 2013 at 3:52 PM, Benn Oshrin 
<>
 wrote:
> Actually, there's a bigger problem in that I left out 2 new files entirely.
> I'll add those in and add this bug fix.
>
> -Benn-
>
> On 9/24/13 8:21 AM, Benn Oshrin wrote:
>>
>> Strange, that's clearly a bug and yet it works fine for me. For a change
>> like this (a small fix after a commit) you can just push it with a
>> message like "additional fix for CO-123". Please push (assuming you're
>> not going to commit the commented out line).
>>
>> Thanks,
>>
>> -Benn-
>>
>> On 9/24/13 5:45 AM, Scott Koranda wrote:
>>>
>>> Hi,
>>>
>>> I pulled the latest code and to get it to work I had to make this
>>> change in CoPerson.php:
>>>
>>> $ git diff CoPerson.php
>>> diff --git a/app/Model/CoPerson.php b/app/Model/CoPerson.php
>>> index 2496e2f..27a5f41 100644
>>> --- a/app/Model/CoPerson.php
>>> +++ b/app/Model/CoPerson.php
>>> @@ -76,7 +76,8 @@ class CoPerson extends AppModel {
>>>         'foreignKey' => 'actor_co_person_id'
>>>       ),
>>>       "CoProvisioningExport" => array('dependent' => true),
>>> -    "CoTandCAgreement" => array('dependent' => true),
>>> +    //"CoTandCAgreement" => array('dependent' => true),
>>> +    "CoTAndCAgreement" => array('dependent' => true),
>>>       // A person can have one or more email address
>>>       "EmailAddress" => array('dependent' => true),
>>>       // We allow dependent=true for co_person_id but not for
>>> actor_co_person_id (see CO-404).
>>>
>>> Is that a bug?
>>>
>>> If so, shall I create a ticket or is this small enough that I should
>>> just push it?
>>>
>>> Thanks,
>>>
>>> Scott
>>>
>>
>>
>