COmanage Developers List

[Marie Huynh <>]

To get the search function working, I put some of the code in index() in StandardController.php.  It seems reusable should search be implemented for other models.  Problem is, index() is already a pretty big function and it would make more sense shifted into paginationConditions.

The problem with paginationConditions() is that it is only called if not $this->requires_person.  Why?  HistoryRecordsController.php and MVPAController.php (and subclasses) will skip paginationConditions().  Subclasses include:

AddressesController.php:class AddressesController extends MVPAController {

EmailAddressesController.php:class EmailAddressesController extends MVPAController {

IdentifiersController.php:class IdentifiersController extends MVPAController {

TelephoneNumbersController.php:class TelephoneNumbersController extends MVPAController {

Is there any reason why we wouldn't bother searching these, or can I go ahead and have paginationConditions() run for all extensions of Standardcontroller so I can shift my code there?

Marie

On Mon, Mar 25, 2013 at 6:37 PM, Benn Oshrin <> wrote:

Wow, I thought it was just me. Made for a fun 13 hour flight.

I'll probably miss all calls this week... calendar is just too hard to figure out, and no meaningful progress to report.

Heather Flanagan <> wrote:

On 3/25/13 10:49 AM, Scott Koranda wrote:


Hi,

We have a scrum on the calendar today.

I caught a nasty cold on the flight home and cannot stop
sneezing and dripping (sorry for the imagery), so I am going
to bail.


No, you caught it at the FIM meeting 'cause I got it too.  Dang it.



I should be around for Wednesday.

same same.

-Heather






Thanks,

Scott