COmanage Developers List

Author: benno
Date: 2013-02-24 11:30:59 -0500 (Sun, 24 Feb 2013)
New Revision: 463

Modified:
   registry/trunk/app/Model/CoPerson.php
   
registry/trunk/app/Plugin/LdapProvisioner/Controller/CoLdapProvisionerTargetsController.php
   registry/trunk/app/Plugin/LdapProvisioner/Model/CoLdapProvisionerTarget.php
   registry/trunk/app/Plugin/LdapProvisioner/Model/LdapProvisioner.php
Log:
Additional cleanup for CO-40/CO-188

Modified: registry/trunk/app/Model/CoPerson.php
===================================================================
--- registry/trunk/app/Model/CoPerson.php       2013-02-24 14:10:46 UTC (rev 
462)
+++ registry/trunk/app/Model/CoPerson.php       2013-02-24 16:30:59 UTC (rev 
463)
@@ -314,35 +314,6 @@
   }
 
   /**
-   * (Re)Provision a CO Person.
-   *
-   * @since  COmanage Registry v0.8
-   * @param  Integer CO Person ID to provision
-   * @throws InvalidArgumentException
-   */
-  
-  public function provision($coPersonId) {
-    // Pull the CO Person record and related data for provisioning.
-    // For now, all provisioning modules get the whole ball of data.
-    
-    $args = array();
-    $args['conditions']['CoPerson.id'] = $coPersonId;
-    
-    $coperson = $this->find('first', $args);
-    
-    if(!empty($coperson)) {
-      // XXX next: UI calls /provision
-      // Pull list of provisioning modules and invoke, passing $coperson
-      
-//      debug($coperson);
-    } else {
-      throw new InvalidArgumentException(_txt('er.cop.unk'));
-    }
-    
-    // Find the CO Provisioning targets for this CO
-  }
-  
-  /**
    * Determine the current status of the provisioning targets for this CO 
Person.
    *
    * @since  COmanage Registry v0.8

Modified: 
registry/trunk/app/Plugin/LdapProvisioner/Controller/CoLdapProvisionerTargetsController.php
===================================================================
--- 
registry/trunk/app/Plugin/LdapProvisioner/Controller/CoLdapProvisionerTargetsController.php
 2013-02-24 14:10:46 UTC (rev 462)
+++ 
registry/trunk/app/Plugin/LdapProvisioner/Controller/CoLdapProvisionerTargetsController.php
 2013-02-24 16:30:59 UTC (rev 463)
@@ -105,7 +105,6 @@
     // Delete an existing CO Provisioning Target?
     $p['delete'] = ($roles['cmadmin'] || $roles['coadmin']);
     
-// Is edit subject to co:x munging attack?
     // Edit an existing CO Provisioning Target?
     $p['edit'] = ($roles['cmadmin'] || $roles['coadmin']);
     

Modified: 
registry/trunk/app/Plugin/LdapProvisioner/Model/CoLdapProvisionerTarget.php
===================================================================
--- 
registry/trunk/app/Plugin/LdapProvisioner/Model/CoLdapProvisionerTarget.php 
2013-02-24 14:10:46 UTC (rev 462)
+++ 
registry/trunk/app/Plugin/LdapProvisioner/Model/CoLdapProvisionerTarget.php 
2013-02-24 16:30:59 UTC (rev 463)
@@ -188,18 +188,12 @@
    */
   
   public function provision($coProvisioningTargetData, $op, $coPersonData) {
-    /*
-    debug($coProvisioningTargetData);
-    debug($op);
-    debug($coPersonData);
-    */
-    
     // First figure out what to do
     $assigndn = false;
     $delete   = false;
     $add      = false;
     
-// XXX Implement or cut ticket to implement other operations
+    // XXX CO-548 - Implement the other ProvisioningActions
     switch($op) {
       case ProvisioningActionEnum::CoPersonReprovisionRequested:
         $assigndn = true;
@@ -238,8 +232,8 @@
     
     // Assemble an LDAP record
     
-// XXX make this configurable, at least as per requirements for initial LIGO 
use cases (cut tickets?)
-// multi-valued attributes can be set via $attributes['mail'][0]
+    // XXX make this configurable, at least as per (CO-549)
+    // multi-valued attributes can be set via $attributes['mail'][0]
     $attributes = array();
     $attributes['objectclass'][] = 'top';
     $attributes['objectclass'][] = 'person';

Modified: registry/trunk/app/Plugin/LdapProvisioner/Model/LdapProvisioner.php
===================================================================
--- registry/trunk/app/Plugin/LdapProvisioner/Model/LdapProvisioner.php 
2013-02-24 14:10:46 UTC (rev 462)
+++ registry/trunk/app/Plugin/LdapProvisioner/Model/LdapProvisioner.php 
2013-02-24 16:30:59 UTC (rev 463)
@@ -27,28 +27,5 @@
   public $cmPluginType = "provisioner";
 
   // Expose Menu Items
-  public $cmPluginMenus = array(
-    /*
-    "cmp" => array("Plugin CMP Title" =>
-                   array('controller' => "ldap_provisioners",
-                         'action'     => "cmp")),
-    // These will automatically have CO ID appended
-    "cos" => array("Plugin CO Title" =>
-                   array('controller' => "ldap_provisioners",
-                         'action'     => "index")),
-    "copeople" => array("Plugin CO People Title" =>
-                        array('controller' => "ldap_provisioners",
-                              'action'     => "index2")),
-    "coconfig" => array("Plugin CO Config Title" =>
-                        array('controller' => "ldap_provisioners",
-                              'action'     => "config")),
-    // This will automatically have CO Person ID and CO ID appended
-    "coperson" => array("Plugin My Account Title" =>
-                        array('controller' => "ldap_records",
-                              'action'     => "view")),
-                              */
-  );
-  
-  // XXX do we need to add this?
-  public $useTable = false;
+  public $cmPluginMenus = array();
 }