COmanage Developers List

[Marie Huynh <>]

On Tue, Oct 23, 2012 at 6:14 AM, Benn Oshrin <> wrote:

Fixed in r389. More comments below...

On 10/22/12 7:27 PM, Marie Huynh wrote:

I've not been able to reproduce this either.  I suspect my system is
simply treating undefined variables as null and Scott's isn't.

That's an interesting thought. What's your value for error_reporting, and what version of PHP are you using?

Aha!  I bumped up the debug level and it shows now.  It doesn't explain all the strange behavior though. 

PHP 5.3.6.

 

There's a good write up at http://kunststube.net/isset which might lead to a revision of our coding style guide.

$email_addresses[0]['EmailAddress']['verified'] doesn't exist.  Benn,
how is the verified field supposed to work?

It's set to 0/false/whatever until the invitation confirmation link is clicked.

Technically, that statement is wrong.  isset() = false so it is undefined, with interpretation apparently varying depending on debug level.

However the problem here was that the form was broken for adding a new email address. It tried to reference $email_addresses, which will never be set on an add operation.

-Benn-