Skip to Content.
Sympa Menu

comanage-dev - Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery

Subject: COmanage Developers List

List archive

Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery


Chronological Thread 
  • From: Marie Huynh <>
  • To: Benn Oshrin <>, comanage-dev <>
  • Subject: Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery
  • Date: Tue, 10 Jul 2012 14:36:50 -0700

Here is the diff for the latest changes, including the addition of the per-CO notify_from email address.

On Wed, Jun 27, 2012 at 7:36 PM, Marie Huynh <> wrote:


In CoInvitesController... is there a way to tell if send() failed? There are a number of different failure scenarios, some of which we might be able to get directly (invalid email address, php not configured correctly, etc) and some of which probably need to be handled by the mail delivery system (valid-looking undeliverable email address, etc).

As of 2.0, it appears that try/catch is the way to do it.  

          try {
            $email->template('coinvite', 'basic')
                  ->emailFormat('html')
                  ->to($orgp['EmailAddress'][0]['mail'])
                  ->viewVars($viewVariables)
                  ->subject(_txt('em.invite.subject', array($this->cur_co['Co']['name'])))
                  ->send();
          } catch(Exception $e) {
            debug('Sending of email failed:');
            $this->Session->setFlash($this->fieldsErrorToString($e), '', array(), 'error');
          }

 

In CoInvites/send.ctp, the string "Email has been sent to" should be turned into a _txt() call. Actually, better yet would be for send.ctp to go away, and an appropriate redirect issued, which the _txt() string put in a flash message. The redirect is probably back to "My Population" for now, though that could change.


 
Also, we still need to handle configuring the mail-from address.

I'm going to split that into another ticket so I can commit this before adding more features.

Attachment: co352
Description: Binary data



  • Re: [comanage-dev] Re: [JIRA] (CO-352) Implement Email Delivery, Marie Huynh, 07/10/2012

Archive powered by MHonArc 2.6.16.

Top of Page