comanage-dev - Re: [comanage-dev] r255 - registry/trunk/app/View/CoNsfDemographics
Subject: COmanage Developers List
List archive
- From: Scott Koranda <>
- To: Marie Huynh <>
- Cc: Benn Oshrin <>,
- Subject: Re: [comanage-dev] r255 - registry/trunk/app/View/CoNsfDemographics
- Date: Wed, 14 Mar 2012 17:59:44 -0500
Hi Marie,
> If we want to do it correctly, that requires adding things to the lang
> file and I'd rather not edit multiple files just to spend more time later
> to strip this kind of stuff out while wondering if we meant to have it in
> for any other reason or if there's anything else I've forgotten to
> remove.
Please make the change and commit it when you take a break
from working on something else.
Thanks,
Scott
> � �
>
> On Wed, Mar 14, 2012 at 1:47 PM, Benn Oshrin
> <[1]>
> wrote:
>
> Sorry, didn't include my observation that changing the text is a quick
> change, and seems worth the minute of effort even if we redo this
> later.
>
> On 3/14/12 4:46 PM, Benn Oshrin wrote:
>
> Hmm, that's just passably grammatical. Might be better if it said
> something like "Are you sure you wish to remove this entry's NSF
> demographic data?"
>
> On 3/14/12 1:03 PM, Marie Huynh wrote:
>
> Are you sure you wish to remove? This action cannot be undone.
>
> The problem was that $c['__CoNsfDemographic']['name'] doesn't exist
> and
> I thought the above sounded fine for an admin-only report page we'd
> talked about scrapping and/or redoing anyway.
>
> On Wed, Mar 14, 2012 at 7:34 AM, Benn Oshrin
> <[2]
>
> <mailto:[3]>>
> wrote:
>
> With this change, what does the pop-up delete confirmation box say
> when you click it?
>
> -Benn-
>
> On 3/12/12 8:04 PM,
> [4]
>
> <mailto:[5]>
> wrote:
>
> Author: marie
> Date: 2012-03-12 20:04:08 -0400 (Mon, 12 Mar 2012)
> New Revision: 255
>
> Modified:
> registry/trunk/app/View/__CoNsfDemographics/index.ctp
> Log:
> co292 undefined index error in view
>
> Modified: registry/trunk/app/View/__CoNsfDemographics/index.ctp
>
> ==============================__==============================__=======
> --- registry/trunk/app/View/__CoNsfDemographics/index.ctp
> 2012-03-12 23:01:57 UTC (rev 254)
> +++ registry/trunk/app/View/__CoNsfDemographics/index.ctp
> 2012-03-13 00:04:08 UTC (rev 255)
> @@ -107,7 +107,6 @@
> print '<button class="deletebutton" title="'
> . _txt('op.delete')
> . '" onclick="javascript:js___confirm_delete(\''
> - .
> _txt(Sanitize::html($c['__CoNsfDemographic']['name']))
> . '\', \''
> . $this->Html->url($args)
> . '\')";>'
>
> References
>
> Visible links
> 1.
> mailto:
> 2.
> mailto:
> 3.
> mailto:
> 4.
> mailto:
> 5.
> mailto:
- [comanage-dev] r255 - registry/trunk/app/View/CoNsfDemographics, svnlog, 03/12/2012
- Re: [comanage-dev] r255 - registry/trunk/app/View/CoNsfDemographics, Benn Oshrin, 03/14/2012
- Re: [comanage-dev] r255 - registry/trunk/app/View/CoNsfDemographics, Marie Huynh, 03/14/2012
- Re: [comanage-dev] r255 - registry/trunk/app/View/CoNsfDemographics, Benn Oshrin, 03/14/2012
- Re: [comanage-dev] r255 - registry/trunk/app/View/CoNsfDemographics, Benn Oshrin, 03/14/2012
- Re: [comanage-dev] r255 - registry/trunk/app/View/CoNsfDemographics, Marie Huynh, 03/14/2012
- Re: [comanage-dev] r255 - registry/trunk/app/View/CoNsfDemographics, Scott Koranda, 03/14/2012
- Re: [comanage-dev] r255 - registry/trunk/app/View/CoNsfDemographics, Marie Huynh, 03/14/2012
- Re: [comanage-dev] r255 - registry/trunk/app/View/CoNsfDemographics, Benn Oshrin, 03/14/2012
- Re: [comanage-dev] r255 - registry/trunk/app/View/CoNsfDemographics, Benn Oshrin, 03/14/2012
- Re: [comanage-dev] r255 - registry/trunk/app/View/CoNsfDemographics, Marie Huynh, 03/14/2012
- Re: [comanage-dev] r255 - registry/trunk/app/View/CoNsfDemographics, Benn Oshrin, 03/14/2012
Archive powered by MHonArc 2.6.16.