COmanage Developers List

[Scott Koranda <>]

On Tue, Mar 13, 2012 at 4:23 PM, Scott Koranda 
<>
 wrote:
> Hi,
>
> CouController.php contains this code in the checkDeleteDependencies()
> method when it is trying to determine if the Cou has any
> children:
>
>      foreach($this->cur_co['Cou'] as $k => $v)
>      {
>        if($v['parent_id'] == $curdata['Cou']['id'])
>        {
>          if($this->restful)
>            $this->restResultHeader(403, "Child COU Exists");
>          else
>            $this->Session->setFlash(_txt('er.cou.child', 
> array(Sanitize::html($curdata['Cou']['name']))), '', array(), 'error');
>
>          return(false);
>        }
>      }
>
>
> Is there any reason that cannot be replaced by
>
>    $childCOUs = $curdata['Cou']['ChildCou'];

Should be

$childCOUs = $curdata['ChildCou'];

Question is the same...

>    if (!empty($childCOUs)){
>        if($this->restful)
>            $this->restResultHeader(403, "Child COU Exists");
>        else
>            $this->Session->setFlash(_txt('er.cou.child', 
> array(Sanitize::html($curdata['Cou']['name']))), '', array(), 'error');
>
>    }
>
> Put another way, since the Cou model has a field where it
> keeps track of its children, why not just check for children?
>
> Thanks,
>
> Scott