COmanage Developers List

[Benn Oshrin <>]

[Back to the dev list]

On 12/20/11 1:31 AM, Marie Huynh wrote:
> +        $this->redirect(array('action' => 'add'));
>
> Does this array need to be defined before being passed?

I think we should be consistent here.

 $arg['action'] = 'add';
 $this->redirect($arg);

seems more readable, and not significantly less compact.

> I used :%s/echo/print/gc.  Do I need to fix the rest of the file too
> even if this ticket doesn't touch those parts?

No. The general rule is only clean up code you touch.

Incidentally, I think we'll end up with some revisions to the style 
guides with Cake 2 based on how things are now done. For example, 
everything must be scoped ('public', 'private', etc), which we've been 
lax with to date. I'm going to try to figure out a way to get as much of 
this as possible cleaned up in the transition.

-Benn-