Skip to Content.
Sympa Menu

comanage-dev - Re: [comanage-dev] Updated Coding Guidelines

Subject: COmanage Developers List

List archive

Re: [comanage-dev] Updated Coding Guidelines


Chronological Thread 
  • From: Scott Koranda <>
  • To: Benn Oshrin <>
  • Cc: comanage-dev <>
  • Subject: Re: [comanage-dev] Updated Coding Guidelines
  • Date: Thu, 15 Dec 2011 22:06:45 -0600

> I've made a significant update to the coding style document.
>
> https://spaces.internet2.edu/display/COmanage/COmanage+Coding+Style
>
> Pretty much none of the existing code meets these guidelines.
>
> At this point, I can hear Marie throwing something at the wall,
> since she can probably guess what's coming up next... the diffs for
> the pending 0.3 changes will need to be brought into alignment with
> these guidelines :)
>
> I'll need to review these guidelines before my next commit as well,
> since there are some changes that don't align with how I had been
> doing things. (For example, the new guides prohibit parentheses
> around parameters passed to 'return'.)
>
> We won't retroactively fix code already committed, but if you touch
> existing code you should bring it up to spec.
>
> Comments and suggestions for changes welcome. I expect this document
> to continue to evolve, albeit somewhat more slowly than it just did.
>

I do support a consistent and sane coding style, but the
length of the document is considerable now, and the detail
fine. We have reached the point of diminishing returns.

Thanks,

Scott




Archive powered by MHonArc 2.6.16.

Top of Page